Run one macOS source test on PRs#2873
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c29974a87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: github.event_name == 'pull_request' | ||
| id: setmatrix_pr | ||
| run: | | ||
| MATRIX_JSON='{\"include\":[{\"os\":\"macos\",\"version\":\"15\",\"arch\":\"aarch64\",\"cache\":true}]}' |
There was a problem hiding this comment.
On pull_request events this matrix now only builds macos-15/aarch64, but run-macos still includes macos-15-intel and its download step requests acton-macos-15-x86_64 (.github/workflows/test.yml:533-554). Since that artifact is no longer uploaded by test-macos on PRs, the Intel smoke-test job will fail at actions/download-artifact before it can run, making PR workflows fail. Either keep the x86_64 producer for PRs or also gate/prune the downstream run-macos matrix for PRs.
Useful? React with 👍 / 👎.
1 participant
Pull request runs currently enqueue the same three macOS source-test variants as the full main and scheduled matrix. Those jobs use scarce runners, so otherwise useful PR feedback can sit behind macOS queue time even when the Linux, package, and downstream app jobs have already finished.
This keeps the primary macOS 15 arm64 source test on pull requests and leaves the full macOS matrix on main pushes, tag pushes, scheduled runs, and manual runs, so broader macOS coverage still happens outside the PR feedback loop.